[mkgmap-dev] [PATCH V2] boundary preparer with quadtree

Mon Feb 6 22:11:27 GMT 2012

Hi Gerd,

I need some time to look through your patch. But after a first short 
look through I wonder if you tried to handle the balancing act between 
keeping the old bnd format and saving your quadtree in an apropriate way.

Using the boundary lister I think have seen that you save each boundary 
but no merged boundary? I see you are saving admin_level=2 and 
additionally admin_level=4 and admin_level=6 etc. I expected that one of 
your improvements is that you are doing the complete merge step during 
preparation so that you save one area (or boundary) with all infos of 
admin_level=2,4 and 6.

Your new mkgmap:boundaryid format mixes multiple information in one tag. 
I think it is better to use the mkgmap:boundaryid for the id only and 
one or more additional tags for your quadtree information.

That's just my first impression. I think your idea is exactly right to 
move the merge step to the preparer. I am not 100% sure if it is 
necessary to save the quadtree node infos. But I am sure you have 
compared the performance :-)

WanMil

> Hi,
>
> attached is the patch that works on linux systems, no functional change to
> v1.
>
> http://gis.19327.n5.nabble.com/file/n5459686/boundary_prep_quadtree_v2.patch
> boundary_prep_quadtree_v2.patch
>
> Gerd
>
> --
> View this message in context: http://gis.19327.n5.nabble.com/PATCH-V2-boundary-preparer-with-quadtree-tp5459686p5459686.html
> Sent from the Mkgmap Development mailing list archive at Nabble.com.
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev