[mkgmap-dev] [PATCH v2] Remove LineClipper artefacts

Mon May 23 19:23:19 BST 2011

I came to the conclusion that the first patch only tries to covers a 
shortcoming of the LineClipper.

I started a small investigation and observed the following problems of 
the LineClipper:
* Lines are split when two subsequent coordinates are equal
* In case a line is closed it's quite probable that two unconnected 
lines are returned by the LineClipper
* The clip algorithm seems to be a bit inefficient because it does not 
check the common case first if both coordinates are within the bounding box

The patch fixes all described problems.
The code in the SeaGenerator the joins the ways after the bounding box 
clipping can be removed because of the LineClipper fixes.

@Steve: Can you have a short look on the patch? The LineClipper was 
committed by you so it might be good to have a small code review.

WanMil

> The patch removes artefacts from the LineClipper that might cause
> floodings.
>
> WanMil
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sea_deljoinartefacts_v2.patch
Url: http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20110523/78d22ab5/attachment.pl 