logo separator

[mkgmap-dev] Preparing patches (Re: POIs for areas)

From Jeffrey Ollie jeff at ocjtech.us on Fri Mar 4 15:09:16 GMT 2011

On Fri, Mar 4, 2011 at 8:48 AM, Torsten Leistikow <de_muur at gmx.de> wrote:
> What is the desired approach on the indentation when a patch has such a
> structure change like removing an if-bracketing?

Changing indentation when removing a nesting level is fine, but it
should be confined to the area where the nesting was removed.

> In my change I also "corrected"
> the indentation of otherwise unchanged lines. Shouldn't such changes be included
> in the patch? If they are not included, how is the indentation then "corrected"?

Whitespace-only changes should be included in a separate patch that
does not change any functionality.  That makes it easier to review

Jeff Ollie

More information about the mkgmap-dev mailing list