[mkgmap-dev] Preparing patches (Re: POIs for areas)

Fri Mar 4 14:48:38 GMT 2011

Marko Mäkelä schrieb am 03.03.2011 22:54:
> Could you elaborate what your patch does? Does it remove the option 
> add-pois-to-areas altogether? Even though an add_poi action would replace
> add-pois-to-areas, I think that we should support both forms for some time.

Sadly this patch disables the add-pois-to-areas option completely. I also would
like to have both capabilities for backward compatibiliy, but in the style
processing the command line arguments are not visible at the moment. So there is
no easy way for testing either whether the addpoi command is set in the style or
whether the command line argument is set.

The trunk version generates in the style processing the basis for the POI
generation for ALL objects regardless the command line argument. During the map
generation the command line argument is test, for whether the available POIs are
generated or not.

In my patch during the style creation only the basis for the POI generation of
the objects with the addpoi command is created. And during the map generation a
POI is ALWAYS created, if for an object the corresponding basis is found.

> You may ignore the rest of this message. I did a too quick read of the patch
> and thought that you had changed accidentally white space in some lines. You
> did that on purpose, because you removed one level of indentation when
> removing the check for the add-pois-to-areas parameter.

I have read the rest of your message, but probably only understood half of it.
(I am neither familiar with eclipse nor with svn, so I hardly now what I am
doing when building my own mkgmap.)

What is the desired approach on the indentation when a patch has such a
structure change like removing an if-bracketing? In my change I also "corrected"
the indentation of otherwise unchanged lines. Shouldn't such changes be included
in the patch? If they are not included, how is the indentation then "corrected"?

Gruss
Torsten