logo separator

[mkgmap-dev] [PATCH v2] Fix so that all polygons are really closed

From WanMil wmgcnfg at web.de on Sun Feb 27 11:59:09 GMT 2011

> On Sun, Feb 27, 2011 at 11:06:22AM +0200, Marko Mäkelä wrote:
>> I am now testing the patch on Finland.
> I got 2386 additional warnings. Some are for thin man_made=pier that
> have been drawn as lines. There is man_made=* in the polygons style
> file. Could we suppress the warnings for certain minor unclosed
> polygons? E.g., something like this:
> building=* | man_made=* | amenity=* | tourism=*
> { add mkgmap:polygon-check=false } [0x13 resolution 24]
> If I disable this rule altogether, the warning count drops from 2386 to
> 476. That is, the selective suppression of the warnings would help a
> lot.

Mmh, I am not a big fan of suppressing warning messages. But I see that 
you have the problem that you only want to use man_made=pier with 
polygons. If you add a "dead" rule to the line style you will loose all 
man_made=pier. Would it help you if I add the tags of the way to the 
warning message? Then you could easily filter the message.

> I would demote the 270 messages about automatic closure to the INFO
> level.


> That would leave 206 messages that need to be checked.
> One more idea: you might add some extra treatment for polygons that are
> more than 1 "lap". For example,
> http://www.openstreetmap.org/browse/way/76559964 comprised of nodes
> 902322231, 902322232, ..., 902322231, 902322232. The second 902322232
> triggered the error.

Is this really a big problem? It is an error in the OSM data and just in 
case this does not happen very often we should not support such errors 
by fixing them automatically.


> 	Marko

More information about the mkgmap-dev mailing list