logo separator

[mkgmap-dev] mkgmap dropping ways with boundary -- newly introduced bug

From Felix Hartmann extremecarver at gmail.com on Wed Jan 26 14:02:30 GMT 2011

On 26.01.2011 14:03, Felix Hartmann wrote:
> On 26.01.2011 14:00, WanMil wrote:
>>> On Tue, Jan 25, 2011 at 11:07:09PM +0100, Felix Hartmann wrote:
>>>> Well I don't know whether I should say this is good news or bad news.
>>>> As 1752 was the merger with the coastline branch - hence not easy to
>>>> find the error as lots of functionality changed.
>>> The good news was that my guess was right. :-)
>>> I guess that you should save and reduce the input that causes the 
>>> error.
>>> Then WanMil should be able to figure out the cause in no time, like he
>>> did for the contourline problem last week.
>>>     Marko
>> I introduced a bug in the Tag class. It implements a kind of specialised
>> HashMap and I added a size counter to be able to remove empty Tag
>> objects. Unfortunately calling the deleteTag method twice with the 
>> same tag
>>     way.deleteTag("highway")
>>     way.deleteTag("highway")
>> caused the new size counter to be decreased twice.
>> This is fixed in r1797 and I have also committed that to the index 
>> branch.
>> Thanks a lot for pointing your fingers on it!
>> WanMil
>> _______________________________________________
> Hmm, I just generated the broken tile, and it seems something else is 
> broke now. I missed about 15KB on a 13.5MB .img. Now however the .img 
> is 16.8MB in size. Maybe many ways are now two times in the map??
> Simply exchanging on tile, furthermore crashed Mapsource when zooming 
> in. Not so sure if the patch was correct...

Sorry, error on my part. I had forgotten that I used another style for 
that single tile. Fix seems to be working allright. The missing streets 
have reappeared.

More information about the mkgmap-dev mailing list