[mkgmap-dev] [PATCH] mkgmap:dead-end-check=false after refactoring

Wed Oct 20 21:55:37 BST 2010

On Tue, Oct 19, 2010 at 09:11:31PM +0100, Steve Ratcliffe wrote:
>
>> How could this check be reinstated in the refactored parser, for both
>> XML and PBF? This code should be easy to find in the old XML-only OSM
>> parser: just look for currentWayStartsWithFIXME in Osm5XmlHandler.java.
>
>I hoped no one would miss it ;)
>
>I couldn't see an easy way of doing it, which is why it was omitted.
>I'm sure it is possible though.

It is possible with a small addition to the hook interface. I tested the 
attached patch with XML input. I hope it uses the correct tab width for 
indentation.

I tried to test with pbf input by converting one of my input tiles with 
Osmosis from splitter's osm.gz to osm.pbf. Unfortunately, splitter 
generates OSM XML 0.5, and Osmosis no longer supports --read-xml-0.5.  
In the end, I downloaded a small area with JOSM and converted that one 
to osm.pbf, before and after removing the fixme attribute from an end 
node.

	Marko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixme-dead-end-check.patch
Type: text/x-diff
Size: 7613 bytes
Desc: not available
Url : http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20101020/79ed5049/attachment.bin 