[mkgmap-dev] Method copyTags(..) in Element.java

Sat Feb 27 13:23:07 GMT 2010

Element.java contains the following implementation of copyTags(Element 
other):

/**
  * Copy the tags of the other element.  Only to be used internally
  * by subclasses.
  * @param other The other element.  All its tags will be copied to this
  * element.
  */
public void copyTags(Element other) {
	if (other.tags != null)
		tags = other.tags.copy();
}

So the copyTags does not add but replace all tags. But only if the other 
element has tags. This is weird. So I think replaceTags would be a 
better name and the other.tags==null case should be handled:

public void replaceTags(Element other) {
	if (other.tags == null)
		tags = null;
	else
		tags = other.tags.copy();
}

Is this ok or are there any side effects I am not aware of?

WanMil