[mkgmap-dev] [PATCH] Option to extend sea sectors at extract bordersFrom Felix Hartmann extremecarver at googlemail.com on Sun Jan 17 23:45:09 GMT 2010
On 18.01.2010 00:13, Mark Burton wrote: > Hi Ronny, > > >> this patch (against 1485) adds a new option for generate-sea: >> "extend-sea-sectors" >> If this option is set, coastlines not reaching the borders of a map will >> be extended with a point at the nearest border. >> This prevents strange things happening at the borders of geofabrik extracts. >> See attached pictures of turkey created with options "polygon" >> (just_polygon.png), "polygon,no-sea-sectors" (noseasectors.png) and >> "polygon,extend-sea-sectors" (with_patch.png). >> >> Would be nice if someone could test and merge it. >> > That looks a useful addition but as you haven't put any comments in > getNextEdgeHit() it's not immediately obvious what it's doing. > > You do have one comment: // create additional points at next border > > Perhaps I'm just stupid, but it doesn't really explain what happens > next. > > The original generate sea code was not well commented but that doesn't > mean that additions to it have to similar. > > Mark > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev at lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > I just tried out this patch on Italy from geofabrik (on trunk plus wanmil's mp patch v3) and it was the first time for me that I got a correct sea generation (using --generate-sea=polygons,no-sea-sectors,extend-sea-sectors), (well the sea was empty so I had to color 0x4b blue in my style-file, but land was correct, however that is a problem still related to wanmil's mp patch v3.) I then tried it on Denmark (which previous to this patch posed problems) and it was working mint too.
- Previous message: [mkgmap-dev] [PATCH] Option to extend sea sectors at extract borders
- Next message: [mkgmap-dev] [PATCH] Option to extend sea sectors at extract borders
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the mkgmap-dev mailing list