[mkgmap-dev] [patch] change bus_stop to Transit Service category and add name / operator

Fri Jul 17 09:30:12 BST 2009

Hi Ben,

On Fri, Jul 17, 2009 at 02:14:36AM -0400, Ben Konrath wrote:
> Here's a patch to change the highway=bus_stop POI to the Transit Service  
> category and add the name and/or operator. As usual, comments are 
> welcome.

Good idea!  This will nicely separate bus stops and train stops.  Maybe
use the same symbol code also for tram stops?

> -highway=bus_stop [0x2f08 resolution 21]
> +highway=bus_stop { name '${name} - ${operator}' | '${name}' | '${operator}' } [0x2f17 resolution 20]

Can we have a variant with ${name} ${ref} to the mix?  Or perhaps something
like this:

underground or train stations:
	${ref|highway-symbol:hbox} $name
tram stops:
	${ref|highway-symbol:box} $name
bus stops:
	${ref|highway-symbol:oval} $name

Nope, unfortunately the Edge 705 would display the highway-symbol:oval
as a substitution character (solid diamond, similar to U+FFFD).

Around here, there usually are at least two stops with the same name,
on each side of the road.  (Four if there are tram stops as well.)
I would map all stops, especially if some of them are only reachable
by bridges or tunnels.

There will be a combinatorial explosion if there is no way to write
this kind of rules:

name += ref
name += operator

I tested this patch on my Edge 705.  Bus stations are still listed with
train stops and train stations in the Ground Transport menu.

Index: mkgmap/resources/styles/default/points
===================================================================

--- mkgmap/resources/styles/default/points	(revision 1087)
+++ mkgmap/resources/styles/default/points	(working copy)
@@ -85,7 +85,8 @@
 amenity=university [0x2c05 resolution 21]
 amenity=zoo [0x2c07 resolution 21]
 
-highway=bus_stop [0x2f08 resolution 21]
+highway=bus_stop | railway=tram_stop | railway=halt | railway=station { name '${name} ${ref} - ${operator}' | '${name} ${ref}' | '${name} - ${operator}' | '${ref} ${operator}' | '${name}' | '${ref}' | '${operator}' }
+highway=bus_stop [0x2f17 resolution 20]
 
 highway=motorway_junction { name '${ref} ${name}' | '${ref}' | '${name}' }
 highway=motorway_junction [0x2000 resolution 16]
@@ -133,7 +134,7 @@
 
 railway=halt [0x2f08 resolution 21]
 railway=station [0x2f08 resolution 20]
-railway=tram_stop [0x2f08 resolution 21]
+railway=tram_stop [0x2f17 resolution 21]
 
 shop=bakers [0x2e02 resolution 20]
 shop=bakery [0x2e02 resolution 20]

Best regards,

	Marko

