[mkgmap-dev] [PATCH] bugfix: default_name wasn't working properly for nodes

Sun Apr 5 23:07:56 BST 2009

Removed some lines that effectively made mkgmap ignore the OSM name  
tag if a default_name was set for nodes. The problem is that this code  
sets the name to the default_name if undefined, but it doesn't look at  
the OSM name tag. It can be removed because the setting of the name is  
done in postConvertRules() one line below anyway (and there it's done  
correctly).

Index: src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java
===================================================================

--- src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java	(revision  
999)
+++ src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java	(working  
copy)
@@ -183,14 +183,6 @@
  		if (foundType == null)
  			return;

-		// If the node does not have a name, then set the name from this
-		// type rule.
-		log.debug("node name", node.getName());
-		if (node.getName() == null) {
-			node.setName(foundType.getDefaultName());
-			log.debug("after set", node.getName());
-		}
-
  		postConvertRules(node, foundType);



