[mkgmap-dev] [PATCH v8] - alpha patch to support road find by name

Mon Mar 23 13:51:29 GMT 2009

Hi Florian,

Thanks for testing the patch.

> A little nitpick (Its always possible to optimize something :) )

Nitpicks are fine.

> > +	// given a list of roads sorted by name and city, build a new
> > +	// list that only contains one entry for each group of roads
> > +	// that have the same name and city and are directly connected
> 
> As it happens i live in a street which is intersected by a roundabout.
> As the roundabout does not have the street name on it this will produce 
> multiple segments. So probably it should be directly connected
> or via a way with "junction=roundabout" ...
> 
> But this is just a little optimization probably for the next generation ;) 

I am sure that some people would prefer that the two roads are not
squashed together in that situation because it would "hide" one of the
roads and so they may think that the one road that has been shown
stops at the roundabout when, in reality, it carries on past the
roundabout. So, given that it's a bunch of work to implement and I'm not
convinced it would be universally popular, I will leave that for
someone else to add.

Cheers,

Mark